RFR: 8317356: Test ClassFile API if it deals with nulls correctly across the whole API [v2]
Adam Sotona
asotona at openjdk.org
Fri Oct 11 16:28:12 UTC 2024
On Fri, 11 Oct 2024 16:21:30 GMT, Chen Liang <liach at openjdk.org> wrote:
>> Please review this patch that adds a test by @nizarbenalla to perform null checks across the ClassFile API. This is an updated version of #20556 that minimizes impact on our implementation code.
>>
>> Notes:
>> 1. There's one change in `MethodHandleProxies` to explicitly use platform class loader instead of `null` for boot class loader. Tests work fine.
>> 2. The null check test uses the same set of classes as CorpusTest to make it suitable for tier 1.
>> 3. The test is not comprehensive; currently it is permissive toward IAE, because sometimes some substitution arguments are invalid, especially primitive ClassDesc or Opcode with wrong types.
>
> Chen Liang has updated the pull request incrementally with one additional commit since the last revision:
>
> asotona review remarks
Looks good to me.
-------------
Marked as reviewed by asotona (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21458#pullrequestreview-2363181465
More information about the core-libs-dev
mailing list