RFR: 8341566: Add Reader.of(CharSequence) [v14]

Chen Liang liach at openjdk.org
Mon Oct 21 17:09:28 UTC 2024


On Mon, 21 Oct 2024 17:00:55 GMT, Jason Mehrens <duke at openjdk.org> wrote:

>> Markus KARG has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed wording according to CSR discussion: '<p> The reader is initially open and reading starts at the first character in the sequence.'
>
> Will the Reader need to catch IndexOutOfBoundsException and BufferUnderFlowException then wrap them as EOFException? I would think these errors should not escape the Reader as is if a source CharBuffer limit is tampered with.  Or is this not an issue?

@jmehrens We have this in our specification:

>  If the sequence changes while the reader is open, e.g. the length changes, the behavior is undefined.

Thus your scenario is not an issue.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21371#issuecomment-2427275496


More information about the core-libs-dev mailing list