RFR: 8341566: Add Reader.of(CharSequence) [v14]

Markus KARG duke at openjdk.org
Wed Oct 23 09:11:11 UTC 2024


On Mon, 21 Oct 2024 17:06:30 GMT, Chen Liang <liach at openjdk.org> wrote:

>> Will the Reader need to catch IndexOutOfBoundsException and BufferUnderFlowException then wrap them as EOFException? I would think these errors should not escape the Reader as is if a source CharBuffer limit is tampered with.  Or is this not an issue?
>
> @jmehrens We have this in our specification:
> 
>>  If the sequence changes while the reader is open, e.g. the length changes, the behavior is undefined.
> 
> Thus your scenario is not an issue.

@liach Alan's latest minor edit request auto-removed your approval from this PR. Kindly asking to reapply your approval. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21371#issuecomment-2431406810


More information about the core-libs-dev mailing list