RFR: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file [v2]

[Alexander Matveev]

On Fri, 25 Oct 2024 21:15:21 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> - merge EmptyFolderTest, EmptyFolderPackageTest and EmptyFolderTestBase in EmptyFolderTest class.
>>  - for .msi packaging still verify the output. It should not contain empty folders from `--input`, but should contain other folders and files from `--input`.
>> - fixed `TKit.assertPathNotEmptyDirectory()` that didn't fail if the given path was not a directory.
>> - renamed `TKit.assertPathNotEmptyDirectory()` into `TKit.assertDirectoryNotEmpty()` for consistency
>> - added `TKit.assertDirectoryEmpty()`
>> - replaced some `TKit.assertFalse()` calls with `TKit.assertTrue()` to improve test log readibilty. Old:
>> 
>> [17:04:16.189] TRACE: assertFalse(): Check [...] path doesn't exist
>> 
>> New:
>> 
>> [17:04:16.189] TRACE: assertTrue(): Check [...] path doesn't exist
>
> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Bugfix

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21721#pullrequestreview-2399656562