Integrated: 8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file
Alexey Semenyuk
asemenyuk at openjdk.org
Mon Oct 28 17:25:01 UTC 2024
On Fri, 25 Oct 2024 20:57:09 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
> - merge EmptyFolderTest, EmptyFolderPackageTest and EmptyFolderTestBase in EmptyFolderTest class.
> - for .msi packaging still verify the output. It should not contain empty folders from `--input`, but should contain other folders and files from `--input`.
> - fixed `TKit.assertPathNotEmptyDirectory()` that didn't fail if the given path was not a directory.
> - renamed `TKit.assertPathNotEmptyDirectory()` into `TKit.assertDirectoryNotEmpty()` for consistency
> - added `TKit.assertDirectoryEmpty()`
> - replaced some `TKit.assertFalse()` calls with `TKit.assertTrue()` to improve test log readibilty. Old:
>
> [17:04:16.189] TRACE: assertFalse(): Check [...] path doesn't exist
>
> New:
>
> [17:04:16.189] TRACE: assertTrue(): Check [...] path doesn't exist
This pull request has now been integrated.
Changeset: 00fe9f7b
Author: Alexey Semenyuk <asemenyuk at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/00fe9f7bdfd245791bca6b5b1b2d0a98d41af221
Stats: 254 lines in 5 files changed: 87 ins; 146 del; 21 mod
8343100: Consolidate EmptyFolderTest and EmptyFolderPackageTest jpackage tests into single java file
Reviewed-by: almatvee
-------------
PR: https://git.openjdk.org/jdk/pull/21721
More information about the core-libs-dev
mailing list