RFR: 8339635: StringConcatFactory optimization for CompactStrings off

Shaojin Wen swen at openjdk.org
Thu Sep 5 23:42:50 UTC 2024


On Thu, 5 Sep 2024 23:20:02 GMT, Chen Liang <liach at openjdk.org> wrote:

>> A small optimization, when CompactStrings is turned off, the coder method is not generated, which improves the startup performance
>
> src/java.base/share/classes/java/lang/System.java line 2641:
> 
>> 2639:             }
>> 2640: 
>> 2641:             public byte stringInitCoder() {
> 
> Why do we expose this as a coder instead of other ways, such as a `boolean hasCompactStrings()`? Are we going to use this coder elsewhere?

Because there is already another method `stringConcatInitialCoder`, stringInitCoder is exposed to keep it consistent with the current code style as much as possible.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20722#discussion_r1746316064


More information about the core-libs-dev mailing list