RFR: 8339635: StringConcatFactory optimization for CompactStrings off

Chen Liang liach at openjdk.org
Thu Sep 5 23:46:49 UTC 2024


On Thu, 5 Sep 2024 23:39:58 GMT, Shaojin Wen <swen at openjdk.org> wrote:

>> src/java.base/share/classes/java/lang/System.java line 2641:
>> 
>>> 2639:             }
>>> 2640: 
>>> 2641:             public byte stringInitCoder() {
>> 
>> Why do we expose this as a coder instead of other ways, such as a `boolean hasCompactStrings()`? Are we going to use this coder elsewhere?
>
> Because there is already another method `stringConcatInitialCoder`, stringInitCoder is exposed to keep it consistent with the current code style as much as possible.

I see now that you've added it in #20675. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20722#discussion_r1746318029


More information about the core-libs-dev mailing list