RFR: 8339538: Wrong timeout computations in DnsClient [v2]

Aleksei Efimov aefimov at openjdk.org
Mon Sep 9 11:42:25 UTC 2024


On Fri, 6 Sep 2024 16:58:20 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Aleksei Efimov has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - guard against possible integer value overflows
>>  - make startTime a local variable
>
> test/jdk/com/sun/jndi/dns/ConfigTests/TimeoutWithEmptyDatagrams.java line 62:
> 
>> 60:     private static final int DNS_CLIENT_MIN_TIMEOUT = 50;
>> 61: 
>> 62:     private long startTime;
> 
> startTime does not need to be an instance variable: consider removing it and make it a local variable in the runTest() method.

Thanks Daniel, made it locat variable in the `runTest` method: 11d0f3d038360c04710d78bd8cd036743f69fe41

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20892#discussion_r1750096686


More information about the core-libs-dev mailing list