RFR: 8339810: Cleanup the code in sun.tools.jar.Main to properly close resources and use ZipFile during extract

[Christian Stein]

On Tue, 10 Sep 2024 05:31:29 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

> Can I please get a review of this change which proposes to address https://bugs.openjdk.org/browse/JDK-8339810?
> 
> As noted in the issue we have a few places in the jar's tool `Main` class where we currently don't close the resources in a try/finally block. The commit in this PR updates the relevant places to use a try-with-resources. Additionally, in the extract() implementation of the `Main` class, we use the `ZipFile` when a JAR file is being extracted. This matches with what we do in the rest of the code in that `Main` class where a jar tool operation is a being run against a file.
> 
> No new test has been added given the nature of this change and existing tests in `test/jdk/tools/jar` continue to pass with this change. tier1, tier2 and tier3 testing is currently in progress.

src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 1508:

> 1506:      * Lists contents of JAR file, via ZipFile.
> 1507:      */
> 1508:     void list(String fname, String files[]) throws IOException {

Suggestion:

    void list(String fname, String[] files) throws IOException {


Synchronize with the array syntax change in (new) line 1490.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20928#discussion_r1751312267