RFR: 8339810: Cleanup the code in sun.tools.jar.Main to properly close resources and use ZipFile during extract [v2]

Jaikiran Pai jpai at openjdk.org
Tue Sep 10 06:17:39 UTC 2024


On Tue, 10 Sep 2024 06:08:45 GMT, Christian Stein <cstein at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Christian's review - array declaration style
>
> src/jdk.jartool/share/classes/sun/tools/jar/Main.java line 1508:
> 
>> 1506:      * Lists contents of JAR file, via ZipFile.
>> 1507:      */
>> 1508:     void list(String fname, String files[]) throws IOException {
> 
> Suggestion:
> 
>     void list(String fname, String[] files) throws IOException {
> 
> 
> Synchronize with the array syntax change in (new) line 1490.

You are right - I missed this line and a few other similar declarations. I've now updated the PR to address them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20928#discussion_r1751317362


More information about the core-libs-dev mailing list