RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v7]

fabioromano1 duke at openjdk.org
Wed Sep 11 12:48:07 UTC 2024


On Wed, 11 Sep 2024 11:48:36 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Merge branch 'patchLeftShift' of https://github.com/fabioromano1/jdk into patchLeftShift
>>  - Removed redundant code
>
> test/jdk/java/math/BigInteger/MutableBigIntegerShiftTests.java line 153:
> 
>> 151: 
>> 152:         return result;
>> 153:     }
> 
> I think this is getting too complex for a test, there's a risk that it is incorrect...
> 
> Is there perhaps a way to have simpler code?

The test cases of the code are the same of the test class for `BigInteger.shiftLeft()`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20008#discussion_r1754390582


More information about the core-libs-dev mailing list