RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v7]

Raffaello Giulietti rgiulietti at openjdk.org
Wed Sep 11 15:37:07 UTC 2024


On Wed, 11 Sep 2024 12:44:54 GMT, fabioromano1 <duke at openjdk.org> wrote:

>> test/jdk/java/math/BigInteger/MutableBigIntegerShiftTests.java line 153:
>> 
>>> 151: 
>>> 152:         return result;
>>> 153:     }
>> 
>> I think this is getting too complex for a test, there's a risk that it is incorrect...
>> 
>> Is there perhaps a way to have simpler code?
>
> The test cases of the code are the same of the test class for `BigInteger.shiftLeft()`.

I see (with obvious adaptations and one more `case`).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20008#discussion_r1754982318


More information about the core-libs-dev mailing list