RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]
Brian Burkhalter
bpb at openjdk.org
Wed Sep 11 16:36:10 UTC 2024
On Wed, 11 Sep 2024 06:00:23 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
>> And you did not get `mswsock.lib: FileDispatcherImpl.obj : error LNK2019: unresolved external symbol TransmitFile`?
>
> Right. This PR moves FileDispatcherImpl.c to libjava, so FileDispatcherImpl.obj is no longer there. I'm guessing that our makefiles don't detect source files that were removed, and Brian didn't run `make clean`.
>From a clean build in the CI with `mswsock.lib` removed:
[2024-09-11T16:00:17,816Z] FileDispatcherImpl.obj : error LNK2019: unresolved external symbol
TransmitFile referenced in function Java_sun_nio_ch_FileDispatcherImpl_transferTo0
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1755143206
More information about the core-libs-dev
mailing list