RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]
Daniel Jeliński
djelinski at openjdk.org
Wed Sep 11 16:51:08 UTC 2024
On Wed, 11 Sep 2024 16:33:28 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Right. This PR moves FileDispatcherImpl.c to libjava, so FileDispatcherImpl.obj is no longer there. I'm guessing that our makefiles don't detect source files that were removed, and Brian didn't run `make clean`.
>
> From a clean build in the CI with `mswsock.lib` removed:
>
>
> [2024-09-11T16:00:17,816Z] FileDispatcherImpl.obj : error LNK2019: unresolved external symbol
> TransmitFile referenced in function Java_sun_nio_ch_FileDispatcherImpl_transferTo0
did you remove mswsock from libjava or from libnio? Libnio libraries are listed [here](https://github.com/openjdk/jdk/blob/f57b6f13e9f375bfd2e8a05afd2b900a4d42285e/make/modules/java.base/Lib.gmk#L89).
There's no FileDispatcherImpl.obj in libnio.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1755161852
More information about the core-libs-dev
mailing list