RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

[Daniel Fuchs]

On Fri, 13 Sep 2024 16:35:04 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

>> Do we know what code loaded NTLMAuthentication? I'd expect it to be loaded by HttpURLConnection, which should have triggered the loading of libnet long before it cares about NTLM.
>
> I would have to check. The failure I observed occurred in both of these tests
> 
> test/jdk/sun/net/www/protocol/http/NoNTLM.java
> test/jdk/sun/net/www/protocol/http/TestTransparentNTLM.java
> 
> and nowhere else.

I see. The test does:

            Class<?> ntlmProxyClass = Class.forName("sun.net.www.protocol.http.NTLMAuthenticationProxy", true, NoNTLM.class.getClassLoader());

so that explains it.

In this case I believe it's fair enough to have NTLMAuthentication trigger the loading of libnet if not loaded already -since we need that library to perform the class initialization properly.

What you have is good to me.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1759183851