RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v5]

Brian Burkhalter bpb at openjdk.org
Fri Sep 13 17:06:08 UTC 2024


On Fri, 13 Sep 2024 16:45:22 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> I would have to check. The failure I observed occurred in both of these tests
>> 
>> test/jdk/sun/net/www/protocol/http/NoNTLM.java
>> test/jdk/sun/net/www/protocol/http/TestTransparentNTLM.java
>> 
>> and nowhere else.
>
> I see. The test does:
> 
>             Class<?> ntlmProxyClass = Class.forName("sun.net.www.protocol.http.NTLMAuthenticationProxy", true, NoNTLM.class.getClassLoader());
> 
> so that explains it.
> 
> In this case I believe it's fair enough to have NTLMAuthentication trigger the loading of libnet if not loaded already -since we need that library to perform the class initialization properly.
> 
> What you have is good to me.

Good! Thanks for the assistance.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20317#discussion_r1759204325


More information about the core-libs-dev mailing list