RFR: 8338918: Remove non translated file name from WinResources resource bundle [v2]

Justin Lu jlu at openjdk.org
Fri Sep 20 17:10:36 UTC 2024


On Fri, 20 Sep 2024 02:53:00 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Move `resource.wxl-file-name` property from `WinResources.properties` files to the new `WinResourcesNoL10N.properties` files. The later are supposed to be excluded from automatic translations.
>
> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Redo removal of `resource.wxl-file-name` property
>  - Revert "8338918: Remove non translated file name from WinResources resource bundle"
>    
>    This reverts commit 9b3c1a59d48ec9e87bd1d4c37c9789ff1656a02c.

SHARED and PLATFORM bundles combined into BUNDLE, which now includes the NoL10N resources for Windows.
This ensures the `resource.wxl-file-name` key/val is no longer localized.

LGTM. Thanks for handling this change.

-------------

Marked as reviewed by jlu (Committer).

PR Review: https://git.openjdk.org/jdk/pull/21100#pullrequestreview-2318812462


More information about the core-libs-dev mailing list