RFR: 8338918: Remove non translated file name from WinResources resource bundle [v2]

Andrey Turbanov aturbanov at openjdk.org
Fri Sep 20 19:22:34 UTC 2024


On Fri, 20 Sep 2024 02:53:00 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Move `resource.wxl-file-name` property from `WinResources.properties` files to the new `WinResourcesNoL10N.properties` files. The later are supposed to be excluded from automatic translations.
>
> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Redo removal of `resource.wxl-file-name` property
>  - Revert "8338918: Remove non translated file name from WinResources resource bundle"
>    
>    This reverts commit 9b3c1a59d48ec9e87bd1d4c37c9789ff1656a02c.

Changes requested by aturbanov (Committer).

src/jdk.jpackage/share/classes/jdk/jpackage/internal/I18N.java line 66:

> 64:     }
> 65: 
> 66:     private final static MultiResourceBundle BUNDLE;

nit: use blessed modifiers order
Suggestion:

    private static final MultiResourceBundle BUNDLE;

-------------

PR Review: https://git.openjdk.org/jdk/pull/21100#pullrequestreview-2319125628
PR Review Comment: https://git.openjdk.org/jdk/pull/21100#discussion_r1769112932


More information about the core-libs-dev mailing list