RFR: 8338918: Remove non translated file name from WinResources resource bundle [v2]

Alexey Semenyuk asemenyuk at openjdk.org
Fri Sep 20 22:45:57 UTC 2024


On Fri, 20 Sep 2024 19:19:39 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:

>> Alexey Semenyuk has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Redo removal of `resource.wxl-file-name` property
>>  - Revert "8338918: Remove non translated file name from WinResources resource bundle"
>>    
>>    This reverts commit 9b3c1a59d48ec9e87bd1d4c37c9789ff1656a02c.
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/I18N.java line 66:
> 
>> 64:     }
>> 65: 
>> 66:     private final static MultiResourceBundle BUNDLE;
> 
> nit: use blessed modifiers order
> Suggestion:
> 
>     private static final MultiResourceBundle BUNDLE;

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21100#discussion_r1769332407


More information about the core-libs-dev mailing list