RFR: 8328313: Archived module graph should allow identical --module-path to be specified during dump time and run time [v3]

[Alan Bateman]

On Fri, 20 Sep 2024 18:16:57 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Prior to this patch, if `--module-path` is specified in the command line:
>> during CDS dump time, full module graph will not be included in the CDS archive;
>> during run time, full module graph will not be used.
>> 
>> With this patch, the full module graph will be included in the CDS archive with the `--module-path` option. During run time, if the same `--module-path` option is specified, the archived module graph will be used.
>> 
>> The checking of module paths between dump time and run time is more lenient compared with the checking of class paths; the ordering of the modules is unimportant, duplicate module names are ignored.
>> E.g. the following is considered a match:
>> dump time      runtime
>> m1,m2             m2,m1
>> m1,m2             m1,m2,m2
>> 
>> I included some [notes](https://bugs.openjdk.org/browse/JDK-8328313?focusedId=14699275&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14699275) in the bug report regarding some changes in the corelib classes.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   trailing whitespace

src/java.base/share/classes/jdk/internal/module/ModuleReferences.java line 105:

> 103:             public byte[] generate(String algorithm) {
> 104:               return ModuleHashes.computeHash(supplier, algorithm);
> 105:             }

Why is JarModuleReader changed to use a file string, is this because of an environment dependency when using a Path?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21048#discussion_r1769487689