RFR: 8328313: Archived module graph should allow identical --module-path to be specified during dump time and run time [v3]

[Calvin Cheung]

On Sat, 21 Sep 2024 06:31:16 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   trailing whitespace
>
> src/java.base/share/classes/jdk/internal/module/ModuleReferences.java line 105:
> 
>> 103:             public byte[] generate(String algorithm) {
>> 104:               return ModuleHashes.computeHash(supplier, algorithm);
>> 105:             }
> 
> Why is JarModuleReader changed to use a file string, is this because of an environment dependency when using a Path?

It is to avoid the following warnings during dump time:

[1.607s][warning][cds,heap  ] Archive heap points to a static field that may be reinitialized at runtime:
[1.607s][warning][cds,heap  ] Field: java/util/zip/ZipFile$Source::builtInFS
[1.607s][warning][cds,heap  ] Value: sun.nio.fs.LinuxFileSystem
...
[1.607s][warning][cds,heap  ] Archive heap points to a static field that may be reinitialized at runtime:
[1.607s][warning][cds,heap  ] Field: sun/nio/fs/DefaultFileSystemProvider::INSTANCE
[1.607s][warning][cds,heap  ] Value: sun.nio.fs.LinuxFileSystemProvider

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21048#discussion_r1770803768