RFR: 8352419: Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Tue Apr 1 19:00:56 UTC 2025
> Make tools/jpackage/share/ErrorTest.java test safely handle the case when native bundling is unavailable on the test host.
>
> Additionally:
> - If native bundling is unavailable on the test host, PackageTest will throw `jtreg.SkippedException` and mark the test as skipped instead of silently doing nothing. This should mark a few jpackage tests "skipped" in tests runs on Alpine Linux that doesn't support either .deb or .rpm packaging.
> - Get rid of the dependency on `jtreg.SkippedException` from `/jdk/test` lib as this exception can be thrown from almost every jpackage test because of the changes in PackageTest. Instead embed `jtreg.SkippedException` classfile in TKit.java source and load it from there. This is a less intrusive alternative to adding
>
> * @library /test/lib
> * @build jtreg.SkippedException
>
> in every jtreg test declaration
Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
- Merge branch 'master' into JDK-8352419
- Fix failure in PackageTestTest when native packaging is not available
- bash ./bin/blessed-modifier-order.sh test/jdk/tools/jpackage/
- 8352419: Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail
- Add PackageType.throwSkippedExceptionIfNativePackagingUnavailable(). Stable order of platform package types. Make PackageTest fail if native packagers are unavailable.
- Get rid of dependency on "/test/lib" tets lib
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24294/files
- new: https://git.openjdk.org/jdk/pull/24294/files/353e3f36..e748f993
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24294&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24294&range=00-01
Stats: 12214 lines in 210 files changed: 8161 ins; 3198 del; 855 mod
Patch: https://git.openjdk.org/jdk/pull/24294.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24294/head:pull/24294
PR: https://git.openjdk.org/jdk/pull/24294
More information about the core-libs-dev
mailing list