RFR: 8352419: Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail [v2]

Alexander Matveev almatvee at openjdk.org
Tue Apr 1 22:10:19 UTC 2025


On Tue, 1 Apr 2025 19:00:56 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Make tools/jpackage/share/ErrorTest.java test safely handle the case when native bundling is unavailable on the test host.
>> 
>> Additionally:
>>  - If native bundling is unavailable on the test host, PackageTest will throw `jtreg.SkippedException` and mark the test as skipped instead of silently doing nothing. This should mark a few jpackage tests "skipped" in tests runs on Alpine Linux that doesn't support either .deb or .rpm packaging.
>>  - Get rid of the dependency on `jtreg.SkippedException` from `/jdk/test` lib as this exception can be thrown from almost every jpackage test because of the changes in PackageTest. Instead embed `jtreg.SkippedException` classfile in TKit.java source and load it from there. This is a less intrusive alternative to adding 
>> 
>>  * @library /test/lib
>>  * @build jtreg.SkippedException
>> 
>> in every jtreg test declaration
>
> Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8352419
>  - Fix failure in PackageTestTest when native packaging is not available
>  - bash ./bin/blessed-modifier-order.sh test/jdk/tools/jpackage/
>  - 8352419: Test tools/jpackage/share/ErrorTest.java#id0 and #id1 fail
>  - Add PackageType.throwSkippedExceptionIfNativePackagingUnavailable(). Stable order of platform package types. Make PackageTest fail if native packagers are unavailable.
>  - Get rid of dependency on "/test/lib" tets lib

Latest commit looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24294#pullrequestreview-2734147109


More information about the core-libs-dev mailing list