RFR: 8350075: Performance difference between SegmentAllocator methods [v2]
Per Minborg
pminborg at openjdk.org
Mon Apr 14 15:33:52 UTC 2025
On Thu, 10 Apr 2025 06:00:48 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to add `@ForceInline` to the `default` methods in `SegmentAllocator` that do not already have it.
>
> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Add benchmark
> - Merge branch 'master' into ms-add-missing-force-inline
> - Add @ForceInline to default methods
Looking at it from another perspective: Why should some default methods be FI and not others? What are the rationales for FI:ing the ones that are and not the ones that are not? With this PR, we would at least be consistent.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23628#issuecomment-2802102823
More information about the core-libs-dev
mailing list