RFR: 8354724: BufferedReader readAllLines and readString methods [v6]
Andrey Turbanov
aturbanov at openjdk.org
Mon Apr 21 08:20:44 UTC 2025
On Fri, 18 Apr 2025 20:10:32 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:
>> Implement the requested methods and add a test thereof.
>
> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>
> 8354724: Remove unused import
test/jdk/java/io/BufferedReader/ReadAll.java line 70:
> 68: int size = rnd.nextInt(2, 16386);
> 69:
> 70: try (FileChannel fc = FileChannel.open(path, CREATE, WRITE);) {
Suggestion:
try (FileChannel fc = FileChannel.open(path, CREATE, WRITE)) {
test/jdk/java/io/BufferedReader/ReadAll.java line 104:
> 102: List<String> lines;
> 103: try (FileReader fr = new FileReader(file);
> 104: BufferedReader br = new BufferedReader(fr);) {
Suggestion:
BufferedReader br = new BufferedReader(fr)) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2052118847
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2052119014
More information about the core-libs-dev
mailing list