RFR: 8354724: BufferedReader readAllLines and readString methods [v6]
Brian Burkhalter
bpb at openjdk.org
Mon Apr 21 19:55:06 UTC 2025
On Mon, 21 Apr 2025 08:17:30 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8354724: Remove unused import
>
> test/jdk/java/io/BufferedReader/ReadAll.java line 70:
>
>> 68: int size = rnd.nextInt(2, 16386);
>> 69:
>> 70: try (FileChannel fc = FileChannel.open(path, CREATE, WRITE);) {
>
> Suggestion:
>
> try (FileChannel fc = FileChannel.open(path, CREATE, WRITE)) {
Fixed in b2c3481.
> test/jdk/java/io/BufferedReader/ReadAll.java line 104:
>
>> 102: List<String> lines;
>> 103: try (FileReader fr = new FileReader(file);
>> 104: BufferedReader br = new BufferedReader(fr);) {
>
> Suggestion:
>
> BufferedReader br = new BufferedReader(fr)) {
Fixed in b2c3481.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2052920558
PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2052920752
More information about the core-libs-dev
mailing list