RFR: 8355328: Improve negative tests coverage for jpackage signing [v2]
Alexey Semenyuk
asemenyuk at openjdk.org
Wed Apr 23 02:30:59 UTC 2025
> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest.
>
> If signing identity validation fails, jpackage outputs three messages constructed from the following string IDs: `error.cert.not.found`, `error.explicit-sign-no-cert`, and `error.explicit-sign-no-cert.advice`.
>
> `TKit.TextStreamVerifier.andThen()` method doesn't work correctly when combining more than two instances of `TKit.TextStreamVerifier` class. To address this bug and analyze jpackage's output for three expected strings when a non-existent signing identity is specified, the `TKit.TextStreamVerifier.andThen()` method was replaced with the `TKit.TextStreamVerifier.Group` class. Changes in other tests are a result of this change.
Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
Fix whitespace
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24786/files
- new: https://git.openjdk.org/jdk/pull/24786/files/a57b5d8a..8d3d9b5f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24786&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24786&range=00-01
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/24786.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24786/head:pull/24786
PR: https://git.openjdk.org/jdk/pull/24786
More information about the core-libs-dev
mailing list