RFR: 8355328: Improve negative tests coverage for jpackage signing [v2]
Alexander Matveev
almatvee at openjdk.org
Wed Apr 23 22:27:59 UTC 2025
On Wed, 23 Apr 2025 02:30:59 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest.
>>
>> If signing identity validation fails, jpackage outputs three messages constructed from the following string IDs: `error.cert.not.found`, `error.explicit-sign-no-cert`, and `error.explicit-sign-no-cert.advice`.
>>
>> `TKit.TextStreamVerifier.andThen()` method doesn't work correctly when combining more than two instances of `TKit.TextStreamVerifier` class. To address this bug and analyze jpackage's output for three expected strings when a non-existent signing identity is specified, the `TKit.TextStreamVerifier.andThen()` method was replaced with the `TKit.TextStreamVerifier.Group` class. Changes in other tests are a result of this change.
>
> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix whitespace
Marked as reviewed by almatvee (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/24786#pullrequestreview-2788796519
More information about the core-libs-dev
mailing list