Integrated: 8355328: Improve negative tests coverage for jpackage signing

Alexey Semenyuk asemenyuk at openjdk.org
Wed Apr 23 22:33:11 UTC 2025


On Tue, 22 Apr 2025 00:43:24 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> Add tests covering `error.explicit-sign-no-cert` error ID to ErrorTest.
> 
> If signing identity validation fails, jpackage outputs three messages constructed from the following string IDs: `error.cert.not.found`, `error.explicit-sign-no-cert`, and `error.explicit-sign-no-cert.advice`.
> 
> `TKit.TextStreamVerifier.andThen()` method doesn't work correctly when combining more than two instances of `TKit.TextStreamVerifier` class. To address this bug and analyze jpackage's output for three expected strings when a non-existent signing identity is specified, the `TKit.TextStreamVerifier.andThen()` method was replaced with the `TKit.TextStreamVerifier.Group` class. Changes in other tests are a result of this change.

This pull request has now been integrated.

Changeset: 669d4d6b
Author:    Alexey Semenyuk <asemenyuk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/669d4d6bfa50ab6ae73d05c6a0b069f4507d298e
Stats:     188 lines in 19 files changed: 117 ins; 18 del; 53 mod

8355328: Improve negative tests coverage for jpackage signing

Reviewed-by: almatvee

-------------

PR: https://git.openjdk.org/jdk/pull/24786


More information about the core-libs-dev mailing list