RFR: 8346610: Make all imports consistent in the FFM API [v3]
Sergey Bylokhov
serb at openjdk.org
Fri Apr 25 07:44:11 UTC 2025
On Thu, 9 Jan 2025 11:47:15 GMT, Per Minborg <pminborg at openjdk.org> wrote:
>> This PR proposes to clean up all the imports in the FFM lib (excluding tests).
>>
>> Passes tier1-tier3
>
> Per Minborg has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' into fix-imports
> - Update copyright year and reformat
> - Merge branch 'master' into fix-imports
> - Fix imports
src/java.base/share/classes/jdk/internal/foreign/abi/DowncallLinker.java line 46:
> 44: import java.util.stream.Stream;
> 45:
> 46: import static java.lang.invoke.MethodHandles.*;
It looks inconsistent that in some places you remove the wildcard (*) imports, while in others you add them.
By the way, where does this convention come from? I believe most of the codebase follows the import order: java → empty line → javax → empty line → other jdk packages in alphabetical order → empty line → repeat the same groups for static imports.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22827#discussion_r2059725341
More information about the core-libs-dev
mailing list