RFR: 8347814: Make all imports consistent in the FFM API tests and benchmarks

Sergey Bylokhov serb at openjdk.org
Fri Apr 25 07:44:57 UTC 2025


On Wed, 19 Feb 2025 09:22:09 GMT, Per Minborg <pminborg at openjdk.org> wrote:

> This PR proposes to make all imports consistent in the FFM API tests and benchmarks.
> 
> This is a follow-up PR from https://github.com/openjdk/jdk/pull/22827
> 
> Passes tier1-3

test/jdk/java/foreign/TestFunctionDescriptor.java line 38:

> 36: import java.util.Optional;
> 37: 
> 38: import static org.testng.Assert.*;

Duplicate my comment: https://github.com/openjdk/jdk/pull/22827/files#r2059725341

It looks inconsistent that in some places you remove the wildcard (*) imports, while in others you add them.

By the way, where does this convention come from? I believe most of the codebase follows the import order: java → empty line → javax → empty line → other jdk packages in alphabetical order → empty line → repeat the same groups for static imports.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23689#discussion_r2059729379


More information about the core-libs-dev mailing list