RFR: 8363972: Loose matching of dash/minusSign in number parsing [v7]
Roger Riggs
rriggs at openjdk.org
Tue Aug 5 17:55:06 UTC 2025
On Tue, 5 Aug 2025 16:28:32 GMT, Justin Lu <jlu at openjdk.org> wrote:
>> Naoto Sato has updated the pull request incrementally with one additional commit since the last revision:
>>
>> refrects review comments
>
> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 720:
>
>> 718: /**
>> 719: * {@return the lenient minus signs} Multiple lenient minus signs
>> 720: * are concatenated to form the returned string.
>
> The surrounding package private methods use since tags.
>
> Suggestion:
>
> * are concatenated to form the returned string.
> * @since 26
It might be clearer to say that each character of the string is a valid minus sign character.
If you want to preserve the option for full support for surrogates it could say codepoints instead of character.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26580#discussion_r2254967444
More information about the core-libs-dev
mailing list