RFR: 8363972: Loose matching of dash/minusSign in number parsing [v7]
Justin Lu
jlu at openjdk.org
Tue Aug 5 18:26:06 UTC 2025
On Tue, 5 Aug 2025 17:49:04 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> src/java.base/share/classes/java/text/DecimalFormatSymbols.java line 720:
>>
>>> 718: /**
>>> 719: * {@return the lenient minus signs} Multiple lenient minus signs
>>> 720: * are concatenated to form the returned string.
>>
>> The surrounding package private methods use since tags.
>>
>> Suggestion:
>>
>> * are concatenated to form the returned string.
>> * @since 26
>
> It might be clearer to say that each character of the string is a valid minus sign character.
> If you want to preserve the option for full support for surrogates it could say codepoints instead of character.
I agree. I think that is a good wording update which naturally covers both the single and multiple minus signs case.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26580#discussion_r2255034183
More information about the core-libs-dev
mailing list