RFR: 8356218: [macos] Document --app-content [v2]

Alexander Matveev almatvee at openjdk.org
Tue Aug 19 22:10:53 UTC 2025


On Tue, 19 Aug 2025 21:03:37 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8356218: [macos] Document --app-content [v2]
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacApplicationBuilder.java line 134:
> 
>> 132:                     .anyMatch(subDir -> contentDir.getFileName().toString()
>> 133:                                                   .equalsIgnoreCase(subDir))) {
>> 134:                 Log.info(MessageFormat.format(I18N.getString(
> 
> Can be simplified down to:
> 
> Log.info(I18N.format("warning.non.standard.contents.sub.dir", contentDir));

Fixed. I copy-paste this code. We have many places with `MessageFormat.format(I18N.getString())`. Should I file follow up bug to clean-up it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26848#discussion_r2286439169


More information about the core-libs-dev mailing list