RFR: 8356218: [macos] Document --app-content [v2]

Alexey Semenyuk asemenyuk at openjdk.org
Tue Aug 19 22:18:36 UTC 2025


On Tue, 19 Aug 2025 22:06:56 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacApplicationBuilder.java line 134:
>> 
>>> 132:                     .anyMatch(subDir -> contentDir.getFileName().toString()
>>> 133:                                                   .equalsIgnoreCase(subDir))) {
>>> 134:                 Log.info(MessageFormat.format(I18N.getString(
>> 
>> Can be simplified down to:
>> 
>> Log.info(I18N.format("warning.non.standard.contents.sub.dir", contentDir));
>
> Fixed. I copy-paste this code. We have many places with `MessageFormat.format(I18N.getString())`. Should I file follow up bug to clean-up it?

Up to you. I think it is sufficient merely not add new `MessageFormat.format()` calls and use `I18N.format()` instead.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26848#discussion_r2286451957


More information about the core-libs-dev mailing list