RFR: 8372787: ModuleReader should throw IOException consistently when using --patch-module and ModuleReader is closed [v4]
Jaikiran Pai
jpai at openjdk.org
Mon Dec 1 12:49:13 UTC 2025
> Can I please get a review of this change which proposes to address the issue noted in https://bugs.openjdk.org/browse/JDK-8372787?
>
> The commit in this PR takes into account the `IllegalStateException` thrown by `JarFile` APIs and wraps them into a `IOException` to conform with the expectations of the `ModuleReader` APIs.
>
> A new jtreg test has been introduced to reproduce the issue and verify the fix. CI testing is currently in progress with this change.
Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
apply review suggestions
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28569/files
- new: https://git.openjdk.org/jdk/pull/28569/files/0037de29..30ce204c
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28569&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28569&range=02-03
Stats: 60 lines in 2 files changed: 42 ins; 14 del; 4 mod
Patch: https://git.openjdk.org/jdk/pull/28569.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28569/head:pull/28569
PR: https://git.openjdk.org/jdk/pull/28569
More information about the core-libs-dev
mailing list