RFR: 8372787: ModuleReader should throw IOException consistently when using --patch-module and ModuleReader is closed [v4]
Alan Bateman
alanb at openjdk.org
Mon Dec 1 15:58:11 UTC 2025
On Mon, 1 Dec 2025 12:49:13 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which proposes to address the issue noted in https://bugs.openjdk.org/browse/JDK-8372787?
>>
>> The commit in this PR takes into account the `IllegalStateException` thrown by `JarFile` APIs and wraps them into a `IOException` to conform with the expectations of the `ModuleReader` APIs.
>>
>> A new jtreg test has been introduced to reproduce the issue and verify the fix. CI testing is currently in progress with this change.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>
> apply review suggestions
> The commit in this PR takes into account the `IllegalStateException` thrown by `JarFile` APIs and wraps them into a `IOException` to conform with the expectations of the `ModuleReader` APIs.
Would it be possible to change the PR description as the current description pre-dates the discussion/diagnosis of the real issue.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/28569#issuecomment-3597344139
More information about the core-libs-dev
mailing list