RFR: 8372787: ModuleReader should throw IOException consistently when using --patch-module and ModuleReader is closed [v4]

Jaikiran Pai jpai at openjdk.org
Mon Dec 1 16:08:38 UTC 2025


On Mon, 1 Dec 2025 15:55:40 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> Would it be possible to change the PR description as the current description pre-dates the discussion/diagnosis of the real issue.

Good point - I've updated it now.

> test/jdk/java/lang/module/ModuleReader/patched/PatchedModuleReaderTest.java line 61:
> 
>> 59:      */
>> 60:     @Test
>> 61:     void testPatchedResourcePresence() throws Exception {
> 
> The existing tests use "found" and "not found" so maybe rename these to testResourceFound and testResourceNotFound.

Done

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28569#issuecomment-3597390016
PR Review Comment: https://git.openjdk.org/jdk/pull/28569#discussion_r2577705747


More information about the core-libs-dev mailing list