RFR: 8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call

Jaikiran Pai jpai at openjdk.org
Wed Dec 3 06:09:57 UTC 2025


On Tue, 2 Dec 2025 00:49:12 GMT, Brian Burkhalter <bpb at openjdk.org> wrote:

> Change the test to print the pathname if `getSpace0` fails with a `RuntimeException`.

test/jdk/java/io/File/GetXSpace.java line 187:

> 185:         out.format("%s (%d):%n", s.name(), s.size());
> 186:         String fmt = "  %-4s total = %12d free = %12d usable = %12d%n";
> 187:         String method = Platform.isWindows() & isCDDrive(s.name()) ? "getCDDriveSpace" : "getSpace";

Hello Brian, pre-existing nit - for what this line is doing, the use of bitwise `&` operator looks like an oversight. Should it have been `&&`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28592#discussion_r2583760668


More information about the core-libs-dev mailing list