RFR: 8372851: Modify java/io/File/GetXSpace.java to print path on failure of native call

Brian Burkhalter bpb at openjdk.org
Wed Dec 3 15:45:34 UTC 2025


On Wed, 3 Dec 2025 06:07:00 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Change the test to print the pathname if `getSpace0` fails with a `RuntimeException`.
>
> test/jdk/java/io/File/GetXSpace.java line 187:
> 
>> 185:         out.format("%s (%d):%n", s.name(), s.size());
>> 186:         String fmt = "  %-4s total = %12d free = %12d usable = %12d%n";
>> 187:         String method = Platform.isWindows() & isCDDrive(s.name()) ? "getCDDriveSpace" : "getSpace";
> 
> Hello Brian, pre-existing nit - for what this line is doing, the use of bitwise `&` operator looks like an oversight. Should it have been `&&`?

Hi @jaikiran. Indeed this looks like an ineffectual mistake but I'll fix it before integrating.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28592#discussion_r2585632311


More information about the core-libs-dev mailing list