RFR: 8356116: [macos] Add logging of sign commands in jpackage
Alexey Semenyuk
asemenyuk at openjdk.org
Wed Dec 3 15:44:19 UTC 2025
On Wed, 3 Dec 2025 03:20:45 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:
> - Added logging of sign commands.
> - Sign commands will be logged with `DEBUG` level. Skipped files and signature removal with `TRACE` to reduce amount of less important messages.
> - Renamed `unsign` to `removeSignature`. I think it is better name.
> - Removed `sign` and `codesigners.accept(path)` will be used instead. Not sure why we need function with one line and we using `codesigners.accept(path)` in other places anyway.
> - Direct call to `codesigners.codesignDir().accept(path)` was changed to `codesigners.accept(path)`. In this case exception will be logged if `codesignDir` is not available and I think it is better for `codesigners.accept(path)` to select code signer vs calling it directly.
Some changes required
src/jdk.jpackage/share/classes/jdk/jpackage/internal/Executor.java line 1:
> 1: /*
The changes to this file imply that logging external commands that jpackage runs is optional. Is it? Why would we want to log some commands but not all?
-------------
Changes requested by asemenyuk (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28623#pullrequestreview-3535683855
PR Review Comment: https://git.openjdk.org/jdk/pull/28623#discussion_r2585622467
More information about the core-libs-dev
mailing list