RFR: 8356116: [macos] Add logging of sign commands in jpackage
Alexander Matveev
almatvee at openjdk.org
Wed Dec 3 23:17:39 UTC 2025
On Wed, 3 Dec 2025 15:38:25 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> - Added logging of sign commands.
>> - Sign commands will be logged with `DEBUG` level. Skipped files and signature removal with `TRACE` to reduce amount of less important messages.
>> - Renamed `unsign` to `removeSignature`. I think it is better name.
>> - Removed `sign` and `codesigners.accept(path)` will be used instead. Not sure why we need function with one line and we using `codesigners.accept(path)` in other places anyway.
>> - Direct call to `codesigners.codesignDir().accept(path)` was changed to `codesigners.accept(path)`. In this case exception will be logged if `codesignDir` is not available and I think it is better for `codesigners.accept(path)` to select code signer vs calling it directly.
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/Executor.java line 246:
>
>> 244: }
>> 245:
>> 246: static String createExecutionResultLogMessage(List<String> args,
>
> What is the reason to bring this function from Log class?
To reuse it between `Log.verbose` and `logger.log`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28623#discussion_r2586904640
More information about the core-libs-dev
mailing list