RFR: 8371446: VectorAPI: Add unit tests for masks from various long values [v3]

Xueming Shen sherman at openjdk.org
Sat Dec 6 00:38:03 UTC 2025


On Fri, 5 Dec 2025 20:07:31 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:

>> Xueming Shen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor update
>
> test/jdk/jdk/incubator/vector/AbstractVectorTest.java line 123:
> 
>> 121:                 boolean[] a = new boolean[l];
>> 122:                 for (int i = 0; i < l; i++) {
>> 123:                     a[i] = (i % 2 == 0);
> 
> Suggestion:
> 
>                     a[i] = (i % 5 == 0);

fixed

> test/jdk/jdk/incubator/vector/templates/Unit-Mask-FromToLong.template line 20:
> 
>> 18:         long[] r = new long[a.length];
>> 19: 
>> 20:         for (int ic = 0; ic < INVOC_COUNT * INVOC_COUNT; ic++) {
> 
> Suggestion:
> 
>         for (int ic = 0; ic < INVOC_COUNT; ic++) {

fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28593#discussion_r2594284950
PR Review Comment: https://git.openjdk.org/jdk/pull/28593#discussion_r2594285037


More information about the core-libs-dev mailing list