RFR: 8371446: VectorAPI: Add unit tests for masks from various long values [v4]
Xueming Shen
sherman at openjdk.org
Mon Dec 8 20:08:57 UTC 2025
On Sat, 6 Dec 2025 00:40:32 GMT, Xueming Shen <sherman at openjdk.org> wrote:
>> test/jdk/jdk/incubator/vector/templates/Unit-BoolUnary-op.template line 6:
>>
>>> 4: }
>>> 5:
>>> 6: @Test(dataProvider = "maskBinaryOpProvider")
>>
>> There is already "boolUnaryOpProvider" data provider can we use that and align the naming?
>
> "boolUnaryOpProvider" is used only by the mask reduction/Unit-BoolReduction-op.template. Renamed it to "boolMaskUnaryOpProvider" to be used by both reduction and unary-op/Unit-BoolUnary-op.template.
>
> - boolMaskUnaryOpProvider
> - boolMaskBinaryOpProvider
> - longMaskProvider
> - maskProvider
It appears adding "mask[i % 5]" to BOOLEAN_MASK_GENERATORS/boolMaskUnaryOpProvider may have exposed a potential bug in ByteVector.reduceLanes(VectorOperators.MUL, vmask). I have made the following updates to separate the "ByteVector.reduceLanes(VectorOperators.MUL, vmask)" issue from this PR.
(1) Removed "mask[i % 5]" from BOOLEAN_MASK_GENERATORS
(2) Restored boolUnaryOpProvider for reduction/Unit-BoolReduction-op.template
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28593#discussion_r2599967667
More information about the core-libs-dev
mailing list