RFR: 8373118: Test java/lang/Thread/virtual/Starvation.java timed out [v7]

[Doug Lea]

On Wed, 17 Dec 2025 00:07:28 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Relax orderings in push
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1300:
> 
>> 1298:             }
>> 1299:             top = s;                                  // back out
>> 1300:             if ((phase & 1) == 0)                     // unlock if external
> 
> I presume the read of `phase` is very much intentional here (otherwise passing in boolean internal as a param would make sense), so it might be worth adding the reason for reading phase on this line? 🤔

Yes. The main reason is that I had needed growArray in bulk-steal exploration (but not committed) and needed version without argument). But then noticed that there's no reason to have  arg for a case that almost never happens.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2626993923