RFR: 8373118: Test java/lang/Thread/virtual/Starvation.java timed out [v7]
Viktor Klang
vklang at openjdk.org
Wed Dec 17 00:09:53 UTC 2025
On Tue, 16 Dec 2025 19:12:24 GMT, Doug Lea <dl at openjdk.org> wrote:
>> Changes signal filtering to avoid possible starvation
>
> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
>
> Relax orderings in push
src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1300:
> 1298: }
> 1299: top = s; // back out
> 1300: if ((phase & 1) == 0) // unlock if external
I presume the read of `phase` is very much intentional here (otherwise passing in boolean internal as a param would make sense), so it might be worth adding the reason for reading phase on this line? 🤔
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2625152528
More information about the core-libs-dev
mailing list