RFR: 8373118: Test java/lang/Thread/virtual/Starvation.java timed out [v7]

Doug Lea dl at openjdk.org
Wed Dec 17 13:16:13 UTC 2025


On Wed, 17 Dec 2025 00:04:29 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Relax orderings in push
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1260:
> 
>> 1258:             ForkJoinTask<?>[] a = array;
>> 1259:             int size = s - base + 1, m;
>> 1260:             if (((a != null && a.length > size) || (a = growArray(a, s)) != null) &&
> 
> Instruction ordering reason to assign the size ahead of the `if`?  🤔 
> 
> 
>             int m;
>             if (((a != null && a.length > (s - base + 1)) || (a = growArray(a, s)) != null) &&

(Now reworked a little...) Well, mainly trying to simply the conditional while avoiding possibly-uninitialized errors

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28797#discussion_r2627024361


More information about the core-libs-dev mailing list