RFR: 8350704: Create tests to ensure the failure behavior of core reflection APIs

Mikhail Yankelevich duke at openjdk.org
Wed Feb 26 16:44:53 UTC 2025


On Tue, 25 Feb 2025 23:50:01 GMT, Chen Liang <liach at openjdk.org> wrote:

> Core reflection's generic signature parsing system is used for many aspects, including annotations and enclosing methods, yet it is under-tested. It is better for us to set up tests to ensure that sensitive error behaviors of core reflection remain the same across implementation updates, such as #19281.
> 
> This patch also includes a JUnit converted version of https://github.com/openjdk/jdk/pull/22581#issuecomment-2521703511 test checking behavior around annotations with duplicate interfaces. Interesting that this causes failure in class, field, and methods (constructors), but not in parameters.
> 
> Testing: jdk-tier 1, jdk-tier 2

test/jdk/java/lang/annotation/MalformedAnnotationTest.java line 30:

> 28:  *          that should stay in refactors
> 29:  * @library /test/lib
> 30:  * @comment

Minor: Do you need the `@comment` here if it's empty?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23788#discussion_r1971956709


More information about the core-libs-dev mailing list