RFR: 8359123: Misleading examples in jmod man page [v2]

Alan Bateman alanb at openjdk.org
Mon Jun 16 18:51:32 UTC 2025


On Sat, 14 Jun 2025 18:16:46 GMT, Ana Maria Mihalceanu <duke at openjdk.org> wrote:

>> Please review my PR. This PR includes the following:
>> 
>> - [x] Fix a small typo in a word and copyright.
>> - [x] Enhance description for `--target-platform`.
>> - [x] Rearrange `jmod create` example from basic to complex.
>
> Ana Maria Mihalceanu has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix whitespaces.
>  - Update description of commands as per code review

src/jdk.jlink/share/man/jmod.md line 205:

> 203:       --libs lib --main-class com.greetings.Main
> 204:       --man-pages man --module-version 1.0
> 205:       --target-platform "macOS-aarch64" greetingsmod

Can you change it to "macos-aarch64" as it is case sensitive.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25772#discussion_r2150642310


More information about the core-libs-dev mailing list