RFR: 8359123: Misleading examples in jmod man page [v2]

Alan Bateman alanb at openjdk.org
Mon Jun 16 18:54:30 UTC 2025


On Sat, 14 Jun 2025 18:16:46 GMT, Ana Maria Mihalceanu <duke at openjdk.org> wrote:

>> Please review my PR. This PR includes the following:
>> 
>> - [x] Fix a small typo in a word and copyright.
>> - [x] Enhance description for `--target-platform`.
>> - [x] Rearrange `jmod create` example from basic to complex.
>
> Ana Maria Mihalceanu has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fix whitespaces.
>  - Update description of commands as per code review

src/jdk.jlink/share/man/jmod.md line 183:

> 181: `--target-platform` *platform*
> 182: :   Specifies the target platform. The value is a string identifying
> 183:     the module's intended platform, typically in the form `<os>-<arch>`.

Maybe we could say that it specifies the target platform when creating a JMOD file that is platform specific. The value is `<os>-<arch>` where `<os>` is the operating system and `<arch>` is the architecture. Examples values are ...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25772#discussion_r2150648312


More information about the core-libs-dev mailing list